Re: [alsa-devel] [PATCH 1/9] ASoC: max98927: Added TDM support

Subject: Re: [PATCH 1/9] ASoC: max98927: Added TDM support

On Fri, Aug 25, 2017 at 05:41:02PM -0700, Ryan Lee wrote:

...

Signed-off-by: Ryan Lee mailto:ryans.lee@maximintegrated.com

This says it's adding support for TDM mode but...

...

• case SND_SOC_DAIFMT_DSP_A:

• format = MAX98927_PCM_FORMAT_TDM_MODE1;
  

• break;
  

• case SND_SOC_DAIFMT_DSP_B:

• format = MAX98927_PCM_FORMAT_TDM_MODE0;
  

• break;
  

  case SND_SOC_DAIFMT_PDM:

• max98927->iface |= SND_SOC_DAIFMT_PDM;
  

• use_pdm = true;
  

  break;

...it looks like it's adding support for two new DSP modes and generally making a bunch of other changes. This probably needs splitting up, or at least a bit more of a changelog.

I wanted to split this patch but changes were all about DSP_A and DSP_B format support. I added more description about this patch and send patch series again.