Dear Jean-Francois Moine,
On Fri, 9 Aug 2013 11:06:23 +0200, Jean-Francois Moine wrote:
we need at least two more compatibles for the audio controller found on Dove and Kirkwood respectively. This is how we are going to distinguish those two, e.g. Kirkwood has SPDIF in which Dove hasn't.
Sebastian,
s/has/hasn't & s/hasn't/has
Are 2 compatibles enough, i.e. "mvebu-audio" and "mbevu-audio-spdif"?
Or:
marvell,kirkwood-audio marvell,dove-audio
Also, we have used "marvell" as prefix for a long time. I know there has been discussion about the stock ticker appreviation, has there been any decision on that already?
Don't know, but, sure, there are still a lot of "mrvl".
Yes, but they are being converted over to 'marvell', I've seen some patches posted. Also, as per Documentation/devicetree/bindings/vendor-prefixes.txt, 'marvell' is the right prefix for Marvell compatible strings.
Also we will need some phandle reference to the audio codec here. As this property is ongoing work in ASoC core, I suggest we wait for it and propose a binding afterwards.
I don't think that we need any reference to the codec here. The glue is done by the audio device. For example, using the (soon?) extended simple audio card:
Have you looked at the Samsung DT bindings for audio:
sound { compatible = "samsung,smdk-wm8994";
samsung,i2s-controller = <&i2s0>; samsung,audio-codec = <&wm8994>; };
it definitely has a codec phandle reference here.
Thomas