On Wed, Nov 15, 2023 at 03:39:43PM +0100, Herve Codina wrote:
The QMC HDLC driver provides support for HDLC using the QMC (QUICC Multichannel Controller) to transfer the HDLC data.
Signed-off-by: Herve Codina <herve.codina@bootlin.com> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> Acked-by: Jakub Kicinski <kuba@kernel.org> --- [ ... ]
+ +static const struct of_device_id qmc_hdlc_id_table[] = { + { .compatible = "fsl,qmc-hdlc" }, + {} /* sentinel */ +}; +MODULE_DEVICE_TABLE(of, qmc_hdlc_driver);
I am a bit puzzled. How does this even compile ? Building powerpc:ppc32_allmodconfig ... failed -------------- Error log: In file included from include/linux/device/driver.h:21, from include/linux/device.h:32, from include/linux/dma-mapping.h:8, from drivers/net/wan/fsl_qmc_hdlc.c:14: drivers/net/wan/fsl_qmc_hdlc.c:783:25: error: 'qmc_hdlc_driver' undeclared here (not in a function); did you mean 'qmc_hdlc_probe'? 783 | MODULE_DEVICE_TABLE(of, qmc_hdlc_driver); Guenter
+ +static struct platform_driver qmc_hdlc_driver = { + .driver = { + .name = "fsl-qmc-hdlc", + .of_match_table = qmc_hdlc_id_table, + }, + .probe = qmc_hdlc_probe, + .remove = qmc_hdlc_remove, +}; +module_platform_driver(qmc_hdlc_driver); + +MODULE_AUTHOR("Herve Codina <herve.codina@bootlin.com>"); +MODULE_DESCRIPTION("QMC HDLC driver"); +MODULE_LICENSE("GPL"); -- 2.41.0