8 Jul
2021
8 Jul
'21
2:07 p.m.
On 7/7/21 9:47 PM, Mark Brown wrote:
On Wed, Jul 07, 2021 at 11:26:13AM +0530, Vijendar Mukunda wrote:
+static inline u32 acp_readl(void __iomem *base_addr) +{
- return readl(base_addr - ACP5x_PHY_BASE_ADDRESS);
+}
I see this was the same for Renoir but it's weird that the read and write functions are substracting rather than adding the base address here. A comment might be good.
We can modify code by providing relative offset from base address which adds base address in readl and writel functions. To make this change, we have to modify original header file. To have sync with our HW team and Firmware teams, we are using same common header file.
We will add comment in the code.