On Wed, Jun 21, 2023 at 05:28:41PM +0300, Maxim Kochetkov wrote:
Yep. But we have to specify TDM parameters (slot masks, slot width, etc) any way. Because there is no default TDM configuration like I2S and so. And pure DSP_A/B mode just have no sense.
No, they make perfect sense and are widely supported - the sample size is chosen based on the hwparams instead of being forced by configuring TDM mode.
Anyway. What do you suggest? Should I perform some refactoring for the driver? Should I move M98090_REG_TDM_FORMAT/M98090_REG_TDM_CONTROL registers setup to the max98090_dai_set_fmt()?
To repeat:
I'm saying there should be some interlock between these two settings, if nothing else setting DSP A mode should force TDM mode with automatically configured slot sizes.