On Mon, Jan 07, 2019 at 10:33:21AM -0600, Pierre-Louis Bossart wrote:
On 1/7/19 9:55 AM, Andy Shevchenko wrote:
On Mon, Jul 16, 2018 at 12:52:40PM +0300, Andy Shevchenko wrote:
Switch the driver to use modern UUID API, i.e. guid_t type and accompanying functions, such as guid_equal().
Any comments on this?
What is the motivation for this change, is this alignment to new APIs or that the legacy code will be removed?
The idea is to get rid of legacy API at some point. At least for now to minimize its use in the kernel.
I don't know enough about this API and I don't know if we can "prove" the changes are harmless, so my main concern is testing and backwards compatibility. This Skylake topology code is far from simple, I don't know if there's anyone that actually understands it and we already have some platforms where the mainline kernel doesn't seem to work due to obscure topology issues, so we might want to leave it alone. "If it ain't broke don't fix it" applies here.