At Wed, 13 May 2009 16:31:26 +0200, Le Torbi wrote:
Hi guys,
I'm new to this list and never contributed anything to such a big open-source project like ALSA, so please forgive me if I make some newbie mistakes. But back the the important stuff: I own a MacBook 3,1 and experienced some sound issues with this. I didn't have no sound, but the sound was quite low in quality and volume. After some research and a lot of wrong ways I stumbled upon bug 0004086 "MacBook 4,1 sounds tinny or not at all " in the ALSA bug tracking system (https://bugtrack.alsa-project.org/alsa-bug/view.php?id=4086) and managed to fix it. Any details can be found in the bug report as well as a link to my patch. My questions now are:
- Could an exprineced ALSA-Coder check my patch for bugs or "newbie
code glitches"? 2. What do I have to do, to get my patch in the official code repository?
Just send your patch to alsa-devel ML and Cc to me. Don't forget to give a proper changelog and your sign-off together.
Also, I recommend to run $LINUX/scripts/checkpatch.pl for your patch and fix the suggested issues before submission.
thanks,
Takashi