On 22.05.2013 18:39, Mark Brown wrote:
On Wed, May 22, 2013 at 04:10:20PM +0200, Florian Meier wrote:
This driver adds support for digital audio (I2S) for the BCM2708 SoC that is used by the Raspberry Pi. External audio codecs can be connected to the Raspberry Pi via P5 header.
Split this up into a patch series, for example one per CPU side driver and one per machine driver. I've given the code a relatively quick run through here, it looks mostly sensible though DT would be nice but there's a few comments.
+static inline void bcm2708_i2s_write_reg(struct bcm2708_i2s_dev *dev,
int reg, u32 val)+{
- dev_dbg(dev->dev, "I2S write to register %p = %x\n",
dev->clk_base + reg, val);- __raw_writel(val, dev->i2s_base + reg);
+}
This all looks like you want to use regmap-mmio.........
Thank you for your comments! I will have a look at them and send a new patch series taking them into account. Before that I will create a patch for the DMA engine driver.