Re: [alsa-devel] Need help fixing pop/click artifacts in an ASOC driver

I've submitted a patch for the pcm512x CODEC, that is relevant to this problem. The patch implements the digital_mute interface, suppressing various clicks and pops, including the loud pop under discussion here. I still feel that fixing the machine driver, so that it doesn't generate the pop at all would be desirable, as I'm not sure whether the digital_mute callback is guaranteed to have muted the device when the clock source takes place.

Does that sound reasonable, or would it be preferable to simply rely on the digital_mute mechanism (assuming the patch is acceptable)?