Re: [PATCH v2 04/17] ASoC: pcm: Honor subformat when configuring runtime

On 18. 09. 23 15:39, Cezary Rojewski wrote:

Subformat options are ignored when setting up hardware parameters and assigning PCM stream capabilities. Account for them to allow for granular format selection.

With introduction of subformats, copying hardware parameters becomes a non-trivial operation. Implement a helper function to make things simple.

Signed-off-by: Cezary Rojewski cezary.rojewski@intel.com

struct snd_soc_pcm_stream { const char *stream_name; u64 formats; /* SNDRV_PCM_FMTBIT_* */

• const struct snd_pcm_subformat *subformats;

I don't think that this extension is mandatory. The whole patch can be skipped if the driver installs the subformat runtime constraint.

Jaroslav