At Fri, 04 May 2007 10:33:16 -0700, Steve Longerbeam wrote:
Steve Longerbeam wrote:
Jaroslav Kysela wrote:
<snip>
Please, resend your patch with this modification. Thanks.
ok, here it is again, with CARD/DEV defaults moved out of alsa.conf and into dsnoop_softvol.conf.
I realized I wasn't handling max_dB < 0 (svol->zero_dB_val = 0) in all cases.
Patch attached again along with an interdiff from my last patch.
Thanks for the patch. Now I checked this thread.
Some suggestions:
- "Capture SoftVol" doesn't sound like a valid mixer name. "Digital Capture Volume" would be more suitable, IMO.
- The range from -30 to 40dB seems too big.
- We don't need a new definition of dsnoop_softvol PCM there as it's specific to HDA-Intel right now. Let's define locally like:
# default with dmix+softvol & dsnoop HDA-Intel.pcm.default { @args [ CARD ] @args.CARD { type string } type asym playback.pcm { ... } capture.pcm { type plug slave.pcm { type softvol slave.pcm { @func concat strings [ "dsnoop:" $CARD ] } control { name "Digital Capture Volume" card $CARD } min_dB -30.0 max_dB 40.0 } } }
Takashi