Re: [alsa-devel] [PATCH] ASoC: Add pinctrl PM to components of active DAIs

On Fri, Oct 25, 2013 at 06:05:44PM +0800, Nicolin Chen wrote:

@@ -807,6 +814,13 @@ int snd_soc_resume(struct device *dev) if (list_empty(&card->codec_dev_list)) return 0;

• /* En-active pins from sleep state */

Just "activate".

• for (i = 0; i < card->num_rtd; i++) {

• struct snd_soc_pcm_runtime *rtd = &card->rtd[i];
  

• struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
  

• pinctrl_pm_select_default_state(cpu_dai->dev);
  

• }

This is going to put the pins into the default state during resume, that'll mean that if we're resuming a device which wasn't in use over suspend it'll be left in the default state after resume instead of in the idle state.

I'd expect the selection of the default state to be part of starting an audio stream and to only do something to active streams on suspend and resume.