On Fri, Oct 17, 2008 at 08:06:21AM +0200, Takashi Iwai wrote:
Matthew Ranostay wrote:
Add support for detecting line out pin insertion and reporting back to userspace with the jack abstraction layer. Line outs are reported with the macro defined SW_LINEOUT_INSERT code.
Signed-off-by: Matthew Ranostay mranostay@embeddedalley.com
Thanks for the patch. Added Dmitry and Mark to Cc for review.
Matthew, as a general comment it would be helpful if you would split your patches up to separate out changes more and post as a series rather than as a single patch. Doing that makes review easier. For example, this patch includes both an addition to the jack reporting API and support for using it in a particular device.
Adding one element should be fine, but I'm wondering whether more and more pin type would come up in future...
That was a fear here - the conclusion was that we deal with that when it gets to be a problem.
SND_JACK_HEADPHONE = 0x0001, SND_JACK_MICROPHONE = 0x0002, SND_JACK_HEADSET = SND_JACK_HEADPHONE | SND_JACK_MICROPHONE,
- SND_JACK_LINEOUT = 0x0004,
};
So, you don't need to judge different line-outs, such as front and rear?
For line outputs I think providing that information in the device name would be better - the reason for providing the distinction in the switch is to provide information when the function of the device attached to the jack changes at runtime. As far as the hardware is concerned one line output is much the same as another.
err = snd_jack_new(codec->bus->card,"Lineout Jack",SND_JACK_LINEOUT, &spec->lineout_jack);
"Line Out" with two words.