Re: [PATCH v2 15/15] ASoC: Intel: sst: Convert to PCI device IDs defines

On Fri, Jul 14, 2023 at 02:26:45PM +0300, Andy Shevchenko wrote:

On Fri, Jul 14, 2023 at 08:56:15PM +0200, Amadeusz Sławiński wrote:

...

Use PCI device IDs from pci_ids.h header.

Perhaps one more sentence to explain why this is okay change, like: "The ACPI IDs are used only internally and lower 16 bits uniquely define the device as vendor ID for Intel is 8086 for all of them."

Suggested-by: ?

...

...

• { PCI_VDEVICE(INTEL, SST_MRFLD_PCI_ID), 0},

• { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_SST_TNG), 0},

That 0 is not needed, OTOH you may use PCI_DEVICE_DATA(..., 0).

And you missed the patch I sent to you, i.e. replacing field and function parameter type to be insigned short. Otherwise it won't work with ACPI.