Hi,
I am curious to know why this has not yet made it upstream. Any particular thing we might be waiting for? Maybe I can help with testing on the hardware?
Damien
On 12/11/14 03:16, Takashi Iwai wrote:
At Wed, 12 Nov 2014 01:09:53 +1100, Damien Zammit wrote:
Revision 7.
Damien Zammit (2): ALSA: usb-audio: Add mixer control for Digidesign Mbox 1 clock source ALSA: usb-audio: Add duplex mode for Digidesign Mbox 1 and enable mixer
sound/usb/mixer_maps.c | 9 ++++ sound/usb/mixer_quirks.c | 129 +++++++++++++++++++++++++++++++++++++++++++++++ sound/usb/quirks-table.h | 41 +++++++++++---- 3 files changed, 170 insertions(+), 9 deletions(-)
Thanks, applied now. The From address was different from signed-off-by address, so I corrected the from address to follow s-o-b. Please keep consistent at the next time.
BTW, there is one thing missing for the support of this device: the mixer resume is likely incomplete. Currently the mixer resume tries to resubmit the cached setups, but it doesn't care about the non-standard commands quirks do. There will be some infrastructure change to enhance quirk's capabilities for resume and others in near future, and let's fix this issue there.
Takashi