On Tue, 12 Jan 2021 14:00:37 +0100, Thierry Reding wrote:
On Tue, Jan 12, 2021 at 09:22:38AM +0100, Takashi Iwai wrote:
On Fri, 08 Jan 2021 14:59:11 +0100, Peter Geis wrote:
The following patches fix tegra-hda on legacy tegra devices. Two issues were discovered preventing tegra-hda from functioning: -The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. -The tegra-hda encounters an input/output error when opening a stream.
Since the only mainline device that used tegra-hda until recently was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices. We can apply it to the tegra30-hda device to resolve the issue across the board. Note that downstream devices used the spdif device instead of hda for hdmi audio. The spdif device lacks a driver on mainline.
-Checkpatch seems to have issues finding [1], but git show has no issue. [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194")
Changelog:
v2: -Added ack and reviewed-by from Jon -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages
Peter Geis (2): clk: tegra30: Add hda clock default rates to clock driver ALSA: hda/tegra: fix tegra-hda on tegra30 soc
Shall I apply both patches via sound git tree?
Or, if you want to take through clk tree, let me know. In that case, feel free to take my ack: Acked-by: Takashi Iwai tiwai@suse.de
There doesn't seem to be a build-time (or even runtime) dependency between the two patches and they fix two independent issues, so they could also go in separately.
Yes. OTOH, it's better to be applied in a shot when you look back at the changes later.
I'm fine either way. From a Tegra perspective, the Tegra30 clock driver is very low activity, so I don't expect any conflicts with between this and some other patches that might go in through the clock tree.
OK, then I queued both patches now to for-linus branch in sound tree.
Thanks!
Takashi