Hello Krzysztof!
On Tue, 2023-02-14 at 15:11 +0100, Krzysztof Kozlowski wrote:
+ interrupts: + maxItems: 1
+ clocks: + minItems: 3
maxItems instead
reg and clocks are required, I suppose I should include both minItems and maxItems for both of them?
No. minItems is implied.
I see. But I think minItems "3" should be included for clocks, right?
+ clock-names: + items: + - const: mclk + - const: sclk + - const: lrclk
The clk suffixes are quite redundant. Don't these inputs have some meaningful name?
They are actually meaningful, as they are usually named in I2S, please refer to the EP93xx User's Guide: https://cdn.embeddedts.com/resource-attachments/ts-7000_ep9301-ug.pdf page 71, for instance.
OK, but then I like the example - if datasheet would use name "clk_clk_this_is_clk" would you still find it meaningful?
Every clock input in clocks is a clock. There is usually no need to say that a clock is a clock...
I see you point, but this is legacy code (sound/soc/cirrus/ep93xx-i2s.c) which took these names back in platform data times... I also see that rather majority of *i2s*.yaml use something "*clk", so maybe it could be accepted for legacy code?