On Mon, 17 Jul 2023 13:44:56 +0200, Amadeusz Sławiński wrote:
PCI IDs for Intel HDA are duplicated across quite a few drivers, due to various configurations and historical reasons. Currently almost all uses of HDA PCI IDs have corresponding comment telling which platform it is. Additionally there are some inconsistencies between drivers about which ID corresponds to which device.
Simplify things, by adding PCI IDs to global header and make use of them in drivers. This allows for removal of comments by having IDs themselves being self explanatory. Additionally it allows for removal of existing inconsistencies by having one source of truth.
Changes from v3:
- Fix double space in commit message title (Ilpo)
- Comment ACPI/PCI ID handling in Atom SST driver (Andy)
- Rebased once again and used --base this time (Andy)
Changes from v2:
- Change CHV to BSW (Andy)
- Fix incorrectly rebased patches (Andy)
- Fix commit message and add suggestions from Andy to SST patch (Andy)
- Rebased on top of Linus tree commit: 4b810bf037e5
Changes from v1:
- Remove BXT-T PCI ID as it is not released (Andy)
- Reorder macros to start from pci_match_id() (Andy)
- Add comment about BXT->APL name change in commit messages (Andy)
- Use SST as part of macro name for DSP only devices (Andy)
- Add PCI IDs for all SST combinations (Andy)
Changes from RFC:
- Sort Intel PCI IDs before adding new ones
- Fix ordering of new PCI IDs (Andy)
- Define all used Intel IDs (Andy)
- Add macros for controller type detection (Andy/Bjorn)
- Add set of patches changing to use above macro (Andy/Bjorn)
- Use PCI_DEVICE_DATA for Intel IDs in sound/pci/hda/hda_intel.c (Andy)
- Commit message wording (Andy)
- Remove unnecessary tabs (Andy)
Amadeusz Sławiński (15): PCI: Sort Intel PCI IDs by number PCI: Add Intel Audio DSP devices to pci_ids.h ASoC: SOF: Remove unused Broxton PCI ID ALSA: Remove unused Broxton PCI ID ALSA: hda: Add controller matching macros ALSA: hda: Use global PCI match macro ALSA: hda/i915: Use global PCI match macro ASoC: Intel: Skylake: Use global PCI match macro ALSA: intel-dsp-config: Convert to PCI device IDs defines ALSA: hda: Convert to PCI device IDs defines ASoC: Intel: avs: Convert to PCI device IDs defines ASoC: Intel: avs: Convert to PCI device IDs defines ASoC: Intel: Skylake: Convert to PCI device IDs defines ASoC: SOF: Intel: Convert to PCI device IDs defines ASoC: Intel: sst: Convert to PCI device IDs defines
Now applied all to sound.git tree, merged to for-next branch.
I pushed a signed tag hda-pci-ids including those (based on 6.5-rc2). git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/hda-pci-ids
Feel free to merge to other trees.
thanks,
Takashi