On Apr 4, 2014, at 9:04 PM, Axel Lin axel.lin@ingics.com wrote:
2014-04-05 5:50 GMT+08:00 Brian Austin brian.austin@cirrus.com:
On Fri, 4 Apr 2014, Axel Lin wrote:
dev_info(&i2c_client->dev, "Cirrus Logic CS42L52, Revision:%02X\n",
reg & 0xFF);
reg & CS42L52_CHIP_REV_MASK);#define CS42L52_CHIP_REV_B0 0x02 -#define CS42L52_CHIP_REV_MASK 0x03 +#define CS42L52_CHIP_REV_B1 0x03
Correct me if I'm wrong, but it looks like you added CS42L52_CHIP_REV_MASK and then replaced that define with CS42L52_CHIP_REV_B1?
The diff looks like that but... Actually what I did is fix CS42L52_CHIP_REV_MASK, it should be 0x07. and while at it, I also add CS42L52_CHIP_REV_B1 (0x03).
-#define CS42L52_CHIP_REV_MASK 0x03 +#define CS42L52_CHIP_REV_B1 0x03 +#define CS42L52_CHIP_REV_MASK 0x07
Regards, Axel
I missed that last line, sorry about that.
Thanks