Re: [alsa-devel] [PATCH 1/3] ASoC: dapm: fix out-of-bounds accesses to DAPM lookup tables

On Fri, Feb 01, 2019 at 11:05:11AM -0600, Pierre-Louis Bossart wrote:

[snd_soc_dapm_mixer_named_ctl] = 8, [snd_soc_dapm_pga] = 9, [snd_soc_dapm_adc] = 10,

• [snd_soc_dapm_input] = 10,
• [snd_soc_dapm_output] = 10,

I'd put these at the same place as mics.

• [snd_soc_dapm_mic] = 10,

This is already in the table (at 5)?

• [snd_soc_dapm_vmid] = 10,

This should be goingn along with supplies and micbiases.

• [snd_soc_dapm_siggen] = 10,

Looks like this should go along with the other sources as mics.

• [snd_soc_dapm_sink] = 10,

This is an output so should be to the end, 11 looks like the right number.

• [snd_soc_dapm_buffer] = 10,
• [snd_soc_dapm_scheduler] = 10,
• [snd_soc_dapm_effect] = 10,
• [snd_soc_dapm_src] = 10,
• [snd_soc_dapm_asrc] = 10,
• [snd_soc_dapm_encoder] = 10,
• [snd_soc_dapm_decoder] = 10,

These feel like they should go along with PGAs.