On Tue, 2010-11-30 at 11:32 +0900, Kuninori Morimoto wrote:
Current FSI-Ak4642 device had niche settings which were FSI2-A-AK4643 and FSI-A-AK4642. This patch add platform_device_id which can control FSI/FSI2, PortA/PortB, AK4642/AK4643 from platform data.
Signed-off-by: Kuninori Morimoto kuninori.morimoto.gx@renesas.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk
but
static struct snd_soc_dai_link fsi_dai_link = {
- .name = "AK4642",
- .stream_name = "AK4642",
- .cpu_dai_name = "fsia-dai", /* fsi A */
- /* .name */
- /* .stream_name */
- /* .cpu_dai_name */
it looks like you forgot to delete these comments.
.codec_dai_name = "ak4642-hifi", -#ifdef CONFIG_MACH_AP4EVB
- .platform_name = "sh_fsi2",
- .codec_name = "ak4642-codec.0-0013",
-#else
- .platform_name = "sh_fsi.0",
- .codec_name = "ak4642-codec.0-0012",
-#endif
- /* .platform_name */
- /* .codec_name */
ditto.
.init = fsi_ak4642_dai_init, .ops = NULL,
no need to set ops to NULL here.
}; @@ -50,14 +52,30 @@ static struct snd_soc_card fsi_soc_card = {
Could you send an incremental update that fixes these issues.
Thanks
Liam