Re: [alsa-devel] [PATCH] ASoC: TWL4030: Disable DACs in analog loopback

On Thursday 30 April 2009 13:53:19 ext Lopez Cruz, Misael wrote:

I got your point, thanks for the explanation. I think that we can take this part of the patch:

• /* Enable master analog loopback mode if any analog switch is enabled*/
• misc = twl4030_read_reg_cache(w->codec, TWL4030_REG_MISC_SET_1);
• if (twl4030->bypass_state & 0xF)

• misc |= TWL4030_FMLOOP_EN;
  

• else

• misc &= ~TWL4030_FMLOOP_EN;
  

• twl4030_write(w->codec, TWL4030_REG_MISC_SET_1, misc);

This bit MISC_SET_1[FMLOOP_EN] needs to set to 1 when any of the analog bypass switches are enabled. Without setting this bit, the loopback is kind of weak.

If it's fine for you, I can create a new patch for supporting the VDL analog bypass switch and add above change in that same patch.

Yes, this is fine. Please send those as a separate patch (the above mentioned and the VDL analog bypass).

Thank you, Péter