Re: [alsa-devel] [linux-pm] Null suspend/resume functions

On Tue 2009-11-17 12:41:25, Mark Brown wrote:

On Tue, Nov 17, 2009 at 12:52:36PM +0100, Pavel Machek wrote:

...

I believe that having few nop functions around the tree should not be huge problem. If it is, you can introduce one shared top function into the core...

The problem I have with that is that for most APIs noop functions are a big fat warning sign that something is going wrong and the API is being abused. This then creates noise and code review problems in the driver code since you've got something that normally suggests a problem.

That still sounds like poor reason to add tests to core. But return 0 function for that purpose should be ok (and should make code easy to review, too).