On Mon, Nov 18, 2013 at 10:25:46AM -0700, Stephen Warren wrote:
On 11/16/2013 03:02 AM, Mark Brown wrote:
Or alternatively should the driver be making the device cache only when runtime PM is disabled?
The regmap is already cache-only when runtime-suspended. However the registers don't get flushed during resume. I suppose that would require only adding one extra call to the PM resume function?
Yup, should probably do that anyway since that's going to bite someone otherwise. We probably want a single operation to flush and enable writes now I think about it, it's the common case.
For some reason, my gut prefers this current solution, but I could be persuaded.
I'm not dead set against doing it this way, it's just that it feels like if it's required something's not working as well as it should.