15 Sep
2009
15 Sep
'09
1:36 p.m.
At Tue, 15 Sep 2009 00:45:03 +0200, pavel.hofman@ivitera.com wrote:
+char *get_binary(char *buffer, int value)
Missing static here. Also a comment to describe what this function does would be helpful.
+static void qtet_akm_set_regs(struct snd_akm4xxx *ak, unsigned char addr,
unsigned char mask, unsigned char value) {
Put the brace in the next line.
+#define AK_CONTROL(xname, xch) { .name = xname, .num_channels = xch }
+#define PCM_12_PLAYBACK_VOLUME "PCM 1/2 Playback Volume" +#define PCM_34_PLAYBACK_VOLUME "PCM 3/4 Playback Volume" +#define PCM_12_CAPTURE_VOLUME "PCM 1/2 Capture Volume" +#define PCM_34_CAPTURE_VOLUME "PCM 3/4 Capture Volume"
Hmm, the naming is always difficult for "pro" boards...
thanks,
Takashi