20 Sep
2023
20 Sep
'23
5:44 a.m.
On Tue, Sep 19, 2023 at 08:42:29AM -0400, Pierre-Louis Bossart wrote:
+static int rtq9128_i2c_write(void *context, const void *data, size_t count) +{
- struct device *dev = context;
- struct i2c_client *i2c = to_i2c_client(dev);
- u8 reg = *(u8 *)data;
- int rg_size;
- BUG_ON(count != 5);
is this really necessary? Just log and error and return? same comments for other functions
Yap, it can be removed. Originally, just use it to check regmap core really follow the declared regmap config.
I think this check may still needed. I'll change the BUG_ON to if/err/return following by your suggestion in v3.
- rg_size = rtq9128_get_reg_size(reg);
- return i2c_smbus_write_i2c_block_data(i2c, reg, rg_size, data + count - rg_size);
+}