Re: [alsa-devel] [PATCH v4 13/15] ASoC: codec/dw-hdmi-audio: add codec driver for dw hdmi audio

On Sat, 2015-02-28 at 21:59 -0500, Yakir Yang wrote:

--- /dev/null +++ b/sound/soc/codecs/dw-hdmi-audio.c @@ -0,0 +1,379 @@ +/*

• • dw-hdmi-codec.c

Doesn't match the filename. Is this line needed?

• • DesignerWare ALSA SoC DAI driver for DW HDMI audio.
• • Copyright (c) 2014, CORPORATION. All rights reserved.
• • Authors: Yakir Yang ykk@rock-chips.com
• • This program is free software; you can redistribute it and/or modify it
• • under the terms and conditions of the GNU General Public License,
• • version 2, as published by the Free Software Foundation.
• • This program is distributed in the hope it will be useful, but WITHOUT
• • ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
• • FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
• • more details.
• • You should have received a copy of the GNU General Public License
• • along with this program. If not, see http://www.gnu.org/licenses/.*
• */

This states that the license is plain GPL v2.

(Missing empty line here.)

+#include <linux/init.h>

[...]

+MODULE_LICENSE("GPL");

So you probably want MODULE_LICENSE("GPL v2");

here.

Paul Bolle