At Thu, 1 Oct 2009 16:24:43 +0100, Mark Brown wrote:
On Thu, Oct 01, 2009 at 09:04:32AM +0200, Takashi Iwai wrote:
commit c877c25170e2655d519b29e91d6c91d5d1a72a6f Author: Takashi Iwai tiwai@suse.de Date: Thu Oct 1 08:33:47 2009 +0200
ASoC: Fix dependency of CONFIG_SND_PXA2XX_SOC_IMOTE2Hrm. This one applies to every board which doesn't use AC97 (some will need SPI but it's the same deal for that). It should probably also be a dependency on the actual I2C controller driver rather than I2C in general since the driver isn't going to do anything if the I2C device isn't actually able to come up, though that'd prevent people doing strange stuff like having the I2C bus driver modular and the audio built in.
Well, the problem is that it unconditionally selects WM8940, and wm8940.c can't be built without CONFIG_I2C (and doesn't make much sense right now). I'd happily remove that I2C Kconfig dependency if you are going to fix wm8940 part.
Takashi