29 Aug
2018
29 Aug
'18
5:26 p.m.
On Wed, Aug 29, 2018 at 06:20:59PM +0300, Codrin Ciubotariu wrote:
On 29.08.2018 17:53, Mark Brown wrote:
That also has the nice bonus that with that I think you'd be able to use the graph card rather than a custom driver?
The main reason for adding a custom driver and not using graph/simple card is the snd_soc_dai_set_sysclk(codec_dai, WM8731_SYSCLK_XTAL, XTAL_RATE, SND_SOC_CLOCK_IN) call. This enables the oscillator found in the wm8731 codec. Since WM8731_SYSCLK_XTAL is not 0, we can't use system-clock-frequency DT property to set it.
Right, that'd be more substantial surgery on the driver to change the DT binding so that it's got a clock provider in it; it'd be nice to do but it's a bit much to make it a blocker so the machine driver is OK.