Re: [PATCH RESEND v1 2/3] ALSA: hda: cs35l41: Fix endian conversions

On Thu, 25 May 2023 15:59:54 +0200, Stefan Binding wrote:

@@ -379,10 +379,10 @@ static int cs35l41_save_calibration(struct cs35l41_hda *cs35l41)

		/* Calibration can only be applied whilst the DSP is not running */
		ret = cs35l41_apply_calibration(cs35l41,

• 						cpu_to_be32(cl->calAmbient),
  

• 						cpu_to_be32(cl->calR),
  

• 						cpu_to_be32(cl->calStatus),
  

• 						cpu_to_be32(cl->calR + 1));
  

• 						(__be32)cpu_to_be32(cl->calAmbient),
  

• 						(__be32)cpu_to_be32(cl->calR),
  

• 						(__be32)cpu_to_be32(cl->calStatus),
  

• 						(__be32)cpu_to_be32(cl->calR + 1));
  

Do we really need those cast? Even if yes, it must be with __force prefix for the endian cast in general.

thanks,

Takashi