11 Jun
2012
11 Jun
'12
2:22 p.m.
+static inline const char *get_mclk_str(enum mclk mclk_sel) +{
- switch (mclk_sel) {
- case MCLK_SYSCLK:
return "MCLK_SYSCLK";- case MCLK_ULPCLK:
return "MCLK_ULPCLK";Why not just drop the MCLK_ from the strings? I'd expect that'll be implied by the context...
I like having some kind of prefix before the alternatives in my enums, even if you could figure out what its for without it.
- /* Digital interface - Clocks */
- SOC_SINGLE("Digital Interface Master Generator Switch",
AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN,1, 0),This enables and disables a 256fs (or similar ratio) clock output from the device?
This is the clocking of the digital interface which is used together with the bit-clock switches when we are in gated mode (see discussions regarding these parameters in earlier review of the codec-driver).
- SOC_SINGLE("Digital Interface 0 Bit-clock Switch",
AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0,1, 0),- SOC_SINGLE("Digital Interface 1 Bit-clock Switch",
AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1,1, 0),I suspect that these are doing what DAIFMT_CONT is for...
See comment above.