Re: [alsa-devel] [PATCH] ASoC: mxs-saif: Use a signed integer for error value

On Tue, Jan 08, 2013 at 10:27:13AM -0200, Fabio Estevam wrote:

• saif->id = of_alias_get_id(np, "saif");
• if (saif->id < 0)

• return saif->id;
  

• ret = of_alias_get_id(np, "saif");
• if (ret < 0)

• return ret;
  

Why not remove said->id completely if we don't need to store a value there? Alternatively, this needs to store the id if the return value is OK.