On Fri, Apr 28, 2017 at 07:46:27AM +0900, Takashi Sakamoto wrote:
On Apr 27 2017 15:51, Vinod Koul wrote:
Due to recent code move, one instance dev_err() was passed a wrong uninitialized pointer for the device, so fix it.
sound/soc/intel/skylake/bxt-sst.c: In function 'bxt_sst_dsp_init': sound/soc/intel/skylake/bxt-sst.c:567:14: warning: 'skl' may be used uninitialized in this function [-Wmaybe-uninitialized] dev_err(skl->dev, "%s: no device\n", __func__); ^
Fixes: 9fe9c7119283 ("ASoC: Intel: Skylake: Move sst common initialization to a helper function") Reported-by: Stephen Rothwell sfr@canb.auug.org.au Signed-off-by: Vinod Koul vinod.koul@intel.com
sound/soc/intel/skylake/bxt-sst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Takashi Sakamoto o-takashi@sakamocchi.jp
Dan and Colin were also going to fix this apparent bug. It's nice to add their contribution, I think.
Suggested-by: Dan Carpenter dan.carpenter@oracle.com Suggested-by: Colin King colin.king@canonical.com
you missed Arnd :)
So based on this rule we should also add: Suggested-by: Arnd Bergmann arnd@arndb.de
http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120225.html http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/120242.html
diff --git a/sound/soc/intel/skylake/bxt-sst.c b/sound/soc/intel/skylake/bxt-sst.c index fde4bc0f35b0..f5e7dbb1ba39 100644 --- a/sound/soc/intel/skylake/bxt-sst.c +++ b/sound/soc/intel/skylake/bxt-sst.c @@ -564,7 +564,7 @@ int bxt_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
ret = skl_sst_ctx_init(dev, irq, fw_name, dsp_ops, dsp, &skl_dev); if (ret < 0) {
dev_err(skl->dev, "%s: no device\n", __func__);
dev_err(dev, "%s: no device\n", __func__);Regards
Takashi Sakamoto