On Tue, Jun 22, 2021 at 09:19:42PM +0800, Jiajun Cao wrote:
The function hda_tegra_first_init() neglects to check the return value after executing platform_get_irq().
hda_tegra_first_init() should check the return value (if negative error number) for errors so as to not pass a negative value to the devm_request_irq().
Fix it by adding a check for the return value irq_id.
Signed-off-by: Jiajun Cao jjcao20@fudan.edu.cn Signed-off-by: Xin Tan tanxin.ctf@gmail.com
sound/pci/hda/hda_tegra.c | 3 +++ 1 file changed, 3 insertions(+)
The original code is probably harmless because it looks like the call to request_irq() would return -EINVAL if irq_id was a negative error code.
But checking the return value is still a good idea, so:
Reviewed-by: Thierry Reding treding@nvidia.com