On Mon, Mar 20, 2017 at 11:08 PM Mark Brown broonie@kernel.org wrote:
On Mon, Mar 20, 2017 at 11:58:31AM +0800, Kai-Heng Feng wrote:
v3: Implicit conversion instead of tenary operator.
v2: Use 'HP Power' instead of individual power events.
As covered in SubmittingPatches this should come after the ---, it doesn't need to end up in the changelogs.
Do you mean https://github.com/git/git/blob/master/Documentation/SubmittingPatches#L197 ? I didn't find any hard rules regarding this, but I'll keep it in mind.
switch (event) {case SND_SOC_DAPM_PRE_PMD:case SND_SOC_DAPM_POST_PMD:case SND_SOC_DAPM_POST_PMU:snd_soc_write(codec, RT286_SET_AMP_GAIN_HPO, AMP_OUT_MUTE);break;case SND_SOC_DAPM_PRE_PMU:To repeat what I said last time:
| After power up we mute the amplifier? That's worthy of a comment...
Please don't ignore review comments, people are generally making them for a reason and are likely to have the same concerns if issues remain unaddressed. Having to repeat the same comments can get repetitive and make people question the value of time spent reviewing. If you disagree with the review comments that's fine but you need to reply and discuss your concerns so that the reviewer can understand your decisions.
IIUC, HPO Power's _POST_PMU is triggered right before power down (_PRE_PMD), hence it's pretty logical to mute the amplifier at this stage. I can't quite see anything wrong here.
So no I didn't ignore your comment, I simply misinterpreted what you meant. Because of the logical assumption, I thought you were talking the unmute part in _PRE_PMU, which I did add in the changelog.
Again, what's the issue here?