Hi Cezary,
I love your patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on tiwai-sound/for-next next-20221026] [cannot apply to linus/master v6.1-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Cezary-Rojewski/ASoC-Intel-av... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20221026135014.1403705-3-cezary.rojewski%40intel.c... patch subject: [PATCH v2 2/9] ASoC: Intel: avs: Introduce PCM power management routines config: loongarch-allyesconfig compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/4d7804359ebb3362c5344e6ba211e0... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Cezary-Rojewski/ASoC-Intel-avs-PCM-power-management/20221026-213834 git checkout 4d7804359ebb3362c5344e6ba211e0619122d9b0 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash sound/soc/intel/avs/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
sound/soc/intel/avs/pcm.c: In function 'avs_dai_suspend_fe_hw_free':
sound/soc/intel/avs/pcm.c:833:37: warning: variable 'rtd' set but not used [-Wunused-but-set-variable]
833 | struct snd_soc_pcm_runtime *rtd; | ^~~ sound/soc/intel/avs/pcm.c: In function 'avs_dai_suspend_be_hw_free': sound/soc/intel/avs/pcm.c:855:37: warning: variable 'rtd' set but not used [-Wunused-but-set-variable] 855 | struct snd_soc_pcm_runtime *rtd; | ^~~
vim +/rtd +833 sound/soc/intel/avs/pcm.c
829 830 static int avs_dai_suspend_fe_hw_free(struct snd_soc_dai *dai, struct avs_dma_data *data) 831 { 832 struct hdac_ext_stream *host_stream;
833 struct snd_soc_pcm_runtime *rtd;
834 int ret; 835 836 rtd = snd_pcm_substream_chip(data->substream); 837 host_stream = data->host_stream; 838 839 /* Store position addresses so we can resume from them later on. */ 840 hdac_stream(host_stream)->lpib = snd_hdac_stream_get_pos_lpib(hdac_stream(host_stream)); 841 host_stream->pphcllpl = readl(host_stream->pphc_addr + AZX_REG_PPHCLLPL); 842 host_stream->pphcllpu = readl(host_stream->pphc_addr + AZX_REG_PPHCLLPU); 843 host_stream->pphcldpl = readl(host_stream->pphc_addr + AZX_REG_PPHCLDPL); 844 host_stream->pphcldpu = readl(host_stream->pphc_addr + AZX_REG_PPHCLDPU); 845 846 ret = __avs_dai_fe_hw_free(data->substream, dai); 847 if (ret < 0) 848 dev_err(dai->dev, "hw_free FE on suspend failed: %d\n", ret); 849 850 return ret; 851 } 852