On Tuesday, March 05, 2013 12:03:45 Bedia, Vaibhav wrote:
I just had a look at it and most the comments that I have on v2 are still applicable and IMO need to be addressed before getting merged. You also don't have a change-log in v3 so I don't understand why you made some changes.
I found that, there is need to upgrade for other TDM slots configs.
I tested driver with 2 - 4 - 6 - 8 channnels I2S (2 slots TDM) with using 1 -2 -3 -4 serializers. and S16_LE (will do S24_3LE) audio.
Did you use aplay for this? If so, what were the parameters used. If not, can you describe how the userspace needs to manage the audio buffer? For anyone looking at leveraging the multi-serializer feature this information is important to highlight.
Yes aplay -D "hw:1,0" -r48000 -fS16_LE -c6 < sine16_6ch.txt or similar. I hear 6ch audio on TAS5086. Also I had generated data and I saw data on oscilloscope. This patch only exteds driver for using more serializers. When you run 2ch. or one serializer), there is same configuration as was in previous driver version.
Best, Michal