Re: [alsa-devel] [PATCH] Make firmware vs driver major version mismatch an error.

At Wed, 03 Feb 2010 10:07:37 +1300, linux@audioscience.com wrote:

From: Eliot Blennerhassett eblennerhassett@audioscience.com

I.e. incompatible firmware will fail driver load.

Signed-off-by: Eliot Blennerhassett eblennerhassett@audioscience.com

Applied now. Thanks.

Takashi

---

pci/asihpi/hpidspcd.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/pci/asihpi/hpidspcd.c b/pci/asihpi/hpidspcd.c index 8c0f251..f58d5a0 100644 --- a/pci/asihpi/hpidspcd.c +++ b/pci/asihpi/hpidspcd.c @@ -103,6 +103,13 @@ short HpiDspCode_Open( goto error2; }

• if (header.version / 10000 != HPI_VER_DECIMAL / 10000) {

• HPI_DEBUG_LOG(ERROR,
  

• 	"Firmware Major Version mismatch  DSP image %d != Driver %d\n",
  

• 	header.version, HPI_VER_DECIMAL);
  

• goto error2;
  

• }
• if (header.version != HPI_VER_DECIMAL) { HPI_DEBUG_LOG(WARNING, "Version mismatch DSP image %d != Driver %d\n",

-- 1.7.0.rc0.8.ge3f67d