Re: [alsa-devel] [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

Hi!

Some of Huawei laptops come with a LED in the micmute key. This patch enables and disable this LED accordingly.

Signed-off-by: Ayman Bagabas ayman.bagabas@gmail.com

NAK.

We already have a LED subsystem.

+#if IS_ENABLED(CONFIG_HUAWEI_LAPTOP) +#include <linux/platform_data/x86/huawei_wmi.h>

+static int (*huawei_wmi_micmute_led_set_func)(bool);

So we should not be doing this.

Thinkpad ACPI module exports its LEDs there, for example.

Thanks,

Pavel