Hi Liao
223cd045719e..bf9d6a21bcd9 100644 --- a/sound/soc/soc-compress.c +++ b/sound/soc/soc-compress.c @@ -810,10 +810,11 @@ int snd_soc_new_compress(struct
snd_soc_pcm_runtime *rtd, int num)
int playback = 0, capture = 0; int i;
- if (rtd->num_codecs > 1) {
- if (rtd->num_cpus > 1 ||
rtd->num_codecs) {
"Compress ASoC: Multicodec not supported\n");return -EINVAL;
"Compress ASoC: Multi CPU/Codec not supported\n");return -ENOTSUPP;so this is an error...
Changing to -ENOTSUPP will prevent below to return error in soc_init_pcm_runtime().
/* create compress_device if possible */ ret = snd_soc_dai_compress_new(cpu_dai, rtd, num); if (ret != -ENOTSUPP) { if (ret < 0) dev_err(card->dev, "ASoC: can't create compress %s\n", dai_link->stream_name); return ret; }
So it is to prevent an error actually. But I agree it is better to return an error when we have an unexpected number of cpu dais. What do you think? @Morimoto-san
Yes, it should return error (= should not prevent error) I think
Thank you for your help !! Best regards --- Kuninori Morimoto