Hi Mark
Thank you for checking patch
+- simple-audio,cpu,dai,clock-gating : if needed, see below
A lot of these are listed as "if needed" - this means they should be listed separately as optional properties rather than in the required properties section.
Sorry, Does this means under Documentation ? Or driver ?
+- simple-audio,codec,controller : phandle for CODEC DAI
It feels like this should just be simple-audio,codec - the controller is just redudnant. Though for idiomatic DT we ought to write something like
simple-audio,codec { simple-audio,dev = &phandle; simple-audio,system-clock-frequency = 122880000; };
rather than have these very long prefixes to the individual property names.
I see. will do in v3
+- simple-audio,codec,dai,name : simple-audio CODEC DAI name +- simple-audio,codec,dai,format : see below +- simple-audio,codec,dai,clock-gating : if needed, see below +- simple-audio,codec,dai,bitclock-inversion : if needed +- simple-audio,codec,dai,bitclock-master : if needed +- simple-audio,codec,dai,frame-inversion : if needed +- simple-audio,codec,dai,frame-master : if needed +- simple-audio,codec,dai,system-clock-frequency : system clock rate if needed
I'm also thinking that for some of the above properties which really should be the same for both ends of the link we should just specify them at the card levle and copy them over. The format and inversion mainly.
I guess it can share format between codec/dai, but it is difficult for inversion. Because it is depends on its default clock polarity. of course we can do simple-audio,platform,dai-bitlock-inversion simple-audio,platform,codec-bitlock-inversion but it is same thing.
Best regards --- Kuninori Morimoto