Re: [alsa-devel] es1938 - patch trying to improve capture hw pointer reads

On Thu, Jan 24, 2008 at 04:40:18PM +0100, Takashi Iwai wrote:

...

...

The patch is, however, unable to apply as is because of coding style problems. Try $LINUXKERNEL/scripts/checkpatch.pl, fix what are suggested there, and repost the patch together with your sign-off.

Will do that when I digged trough the details (have to learn about signing).

See $LINUX/Documentation/SubmittingPatches.

Appended is a cleaned up version of the patch. checkpatch.pl is now only mucking about the '#if 0' commented out old branch. Should this be removed or the if-else parts exchanged, which probably will calm down checkpatch.pl ?

Have to check compilation, then I will send a signed version.

Hermann