15 Jul
2010
15 Jul
'10
9:59 a.m.
On Thu, 15 Jul 2010, Axel Lin wrote:
I agree that it is good to release resources at the same level, where they have been acquired. But I prefer to follow the maintainer/author's coding style.
Yeah, unless that "style" is a bug. IMHO this design is just buggy, unmaintainable, error-prone, and unjustified.
For the changes in other drivers, I'd like to see Liam and Mark's comments. Or if the driver maintainers request it, I can fix it.
Well, as the author of sound/soc/codecs/wm8978.c, I'd be happy if you change it in this way;) And also move the
kfree(wm8978);
line from wm8978_unregister() to wm8978_i2c_remove().
Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/