Re: [PATCH v2 1/2] ASoC: google: dt-bindings: Add sc7280-herobrine machine bindings

Quoting Srinivasa Rao Mandadapu (2021-09-13 06:17:41)

diff --git a/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml new file mode 100644 index 0000000..e0d705f --- /dev/null +++ b/Documentation/devicetree/bindings/sound/google,sc7280-herobrine.yaml @@ -0,0 +1,169 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/google,sc7280-herobrine.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Google SC7280-Herobrine ASoC sound card driver

+maintainers:

• • Srinivasa Rao Mandadapu srivasam@codeaurora.org
• • Judy Hsiao judyhsiao@chromium.org

+description:

• This binding describes the SC7280 sound card which uses LPASS for audio.

+properties:

• compatible:
• enum:

•  - google,sc7280-herobrine
  

• audio-routing:
• $ref: /schemas/types.yaml#/definitions/non-unique-string-array
• description:

•  A list of the connections between audio components. Each entry is a
  

•  pair of strings, the first being the connection's sink, the second
  

•  being the connection's source.
  

• model:
• $ref: /schemas/types.yaml#/definitions/string
• description: User specified audio sound card name
• "#address-cells":
• const: 1
• "#size-cells":
• const: 0

+patternProperties:

• "^dai-link@[0-9a-f]$":
• description:

•  Each subnode represents a dai link. Subnodes of each dai links would be
  

•  cpu/codec dais.
  

• type: object
• properties:

•  link-name:
  

•    description: Indicates dai-link name and PCM stream name.
  

•    $ref: /schemas/types.yaml#/definitions/string
  

•    maxItems: 1
  

•  reg:
  

•    maxItems: 1
  

•    description: dai link address.
  

•  cpu:
  

•    description: Holds subnode which indicates cpu dai.
  

•    type: object
  

•    properties:
  

•      sound-dai: true
  

Shouldn't sound-dai be required?

•  codec:
  

•    description: Holds subnode which indicates codec dai.
  

•    type: object
  

•    properties:
  

•      sound-dai: true
  

Shouldn't sound-dai be required? I don't know but maybe also additional properties is false for this node too?

• required:

•  - link-name
  

•  - cpu
  

•  - codec
  

Should 'reg' be required?

• additionalProperties: false