Re: [alsa-devel] [patch 1/2] alsa: ASoC driver for s6000 I2S interface

On 03/27/2009 05:20 PM, Mark Brown wrote:

...

...

Any reason to expose these to users?

...

This was an attempt to avoid symbol exports.. I'll move everything to s6000-i2s.c and export the three necessary functions.

Which functions are you exporting? None of this looked like anything that I'd expect to see used outside of the driver.

s6000_i2s_start and s6000_i2s_stop are called in s6000_pcm_trigger and s6000_i2s_int_sources is called in the interrupt handler.

s6000_i2s_start can't be called from the dai's trigger callback on playback as the data sheet is very explicit about the order of enabling dma and i2s.

s6000_i2s_stop is called there for consistency. The order on disabling is uncritical.

Daniel