Re: [alsa-devel] [PATCH] Add a new hp-laptop model for Conexant 5066, tested on HP G60

2010-09-02 10:26, Takashi Iwai skrev:

At Thu, 02 Sep 2010 08:47:50 +0200, David Henningsson wrote:

...

This new model adds the following functionality to HP G60:

• Automute of internal speakers
• Autoswitch of internal/external mics
• Remove SPDIF not physically present

BugLink: http://launchpad.net/bugs/587388 Cc: stable@kernel.org Signed-off-by: David Henningsson david.henningsson@canonical.com

Alsa-info: http://launchpadlibrarian.net/54727125/alsa-info.txt_internalmicworking

Thanks for the patch.

The change looks good to me, but could you fix errors reported by checkpatch.pl and repost?

Sure. I let one 80+ warning stay because I thought it'd look ugly and less consistent with the 80+ surroundings otherwise. Let me know if you'd like me to fix that one as well.