On Fri, Jan 13, 2023 at 8:55 AM Laurent Pinchart laurent.pinchart@ideasonboard.com wrote:
On Fri, Jan 13, 2023 at 09:46:49AM +0200, Laurent Pinchart wrote:
On Fri, Jan 13, 2023 at 07:23:18AM +0100, Christoph Hellwig wrote:
This driver depends on ARM && ARCH_SHMOBILE, but ARCH_SHMOBILE can only be set for each/sh, making the driver dead code except for the COMPILE_TEST case.
Signed-off-by: Christoph Hellwig hch@lst.de
No objection from me.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
To expand a little bit on this, ARCH_SHMOBILE used to be set for the ARM-based shmobile SoCs too, until
commit 08e735233ea29b17bfec8e4cb302e799d9f920b8 Author: Geert Uytterhoeven geert+renesas@glider.be Date: Tue Aug 28 17:10:10 2018 +0200
ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS platform dependencies. Hence finish the conversion from ARCH_SHMOBILE to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS"). Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>merged in v4.20. The DRM shmobile driver's Kconfig entry wasn't updated, making it dead code indeed.
Note that it wasn't updated because this driver was not used on Renesas ARM platforms, due to the lack of DT bindings and DT support, so it didn't make sense to make it selectable.
I haven't tested this driver in ages, hence my lack of objection, but someone may want to keep it for the pre-R-Car ARM SoCs.
Indeed, this driver should work with the R-Mobile A1 (which made it into orbit, so we could call it the first member of R-Space ;-) and SH-Mobile AG5 SoCs. The major blocker is the lack of DT bindings.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds