-----Original Message----- From: Andy Shevchenko andriy.shevchenko@linux.intel.com Sent: Friday, May 10, 2024 11:13 PM To: Ding, Shenghao shenghao-ding@ti.com Cc: broonie@kernel.org; lgirdwood@gmail.com; perex@perex.cz; pierre- louis.bossart@linux.intel.com; 13916275206@139.com; alsa-devel@alsa- project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; bard.liao@intel.com; yung-chuan.liao@linux.intel.com; Lu, Kevin <kevin- lu@ti.com>; cameron.berkenpas@gmail.com; tiwai@suse.de; Xu, Baojun baojun.xu@ti.com; soyer@irl.hu; Baojun.Xu@fpt.com Subject: [EXTERNAL] Re: [PATCH v4 1/3] ALSA: ASoc/tas2781: Fix wrong loading calibrated data sequence
On Fri, May 10, 2024 at 11: 41: 19AM +0800, Shenghao Ding wrote: > Calibrated data will be set to default after loading DSP config params, > which will cause speaker protection work abnormally. Reload calibrated > data after loading ZjQcmQRYFpfptBannerStart This message was sent from outside of Texas Instruments. Do not click links or open attachments unless you recognize the source of this email and know the content is safe. If you wish to report this message to IT Security, please forward the message as an attachment to phishing@list.ti.com
ZjQcmQRYFpfptBannerEnd On Fri, May 10, 2024 at 11:41:19AM +0800, Shenghao Ding wrote:
Calibrated data will be set to default after loading DSP config params, which will cause speaker protection work abnormally. Reload calibrated data after loading DSP config params.
Fixes: ef3bcde75d06 ("ASoc: tas2781: Add tas2781 driver")
How on earth this can be a fix?..
Removing the declaration of tasdevice_prmg_calibdata_load is a part of fix. Loading calibrated data after loading dsp program become a redundance.
-// Copyright (C) 2022 - 2023 Texas Instruments Incorporated +// Copyright (C) 2022 - 2024 Texas Instruments Incorporated
...
-int tasdevice_prmg_calibdata_load(void *context, int prm_no);
-- With Best Regards, Andy Shevchenko