On Thu, May 07, 2015 at 01:28:39PM -0500, Pierre-Louis Bossart wrote:
On 5/7/15 7:51 AM, Mark Brown wrote:
You shouldn't be using of_get_named_gpio() for DT stuff either, use gpiod_get() which follows the usual pattern of taking a string which is used to do the lookup with whatever firmware is in use.
But to Bard's credit the use of_get_named_gpio() is pretty common - i see 18 occurrences in soc/codecs alone, others will have the same problem... we talked internally (RafaelW, Darren Hart, LiamG and me) about reaching out to gpio and audio maintainers and aligning some sort of coordinated change to the gpiod framework w/ guidance to developers, did that thread start?
I'm not sure there's any particular need for coordination here, the APIs are in place already - the gpiod_ APIs will already transparently look up both ACPI and DT (see __gpiod_get_index() for the implementation) and new drivers should really be using gpiod_ anyway regardless of trying to do both ACPI and DT.