30 Jul
2018
30 Jul
'18
12:21 p.m.
On Mon, Jul 30, 2018 at 10:46:14AM +0100, Jon Hunter wrote:
On 27/07/18 13:59, Jorge Sanjuan wrote:
- if (params_channels(params) != 2)
- if (params_channels(params) > 8) return -EINVAL;
For normal I2S mode, channels should always be 2 and so it could be worth checking if we are using TDM mode here or not.
Yes, there's some question if a multi-channel I2S setup is going to be all the left channels then all the right channels, have multiple data lines in parallel (this especially common for high end applications) or something else. Usually it's safer to use a DSP mode for those.
Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.